From 044f1054e38474d687df9a1e98c94f24582a663c Mon Sep 17 00:00:00 2001 From: franck cuny Date: Wed, 2 Jun 2010 11:35:59 +0200 Subject: move code to roles --- lib/MooseX/Net/API/Meta/Method/APIDeclare.pm | 49 ++++++++++++++++++++++++++++ 1 file changed, 49 insertions(+) create mode 100644 lib/MooseX/Net/API/Meta/Method/APIDeclare.pm (limited to 'lib/MooseX/Net/API/Meta/Method') diff --git a/lib/MooseX/Net/API/Meta/Method/APIDeclare.pm b/lib/MooseX/Net/API/Meta/Method/APIDeclare.pm new file mode 100644 index 0000000..4ad5150 --- /dev/null +++ b/lib/MooseX/Net/API/Meta/Method/APIDeclare.pm @@ -0,0 +1,49 @@ +package MooseX::Net::API::Meta::Method::APIDeclare; + +use Moose::Role; +use MooseX::Net::API::Error; + +has options => ( + is => 'ro', + traits => ['Hash'], + isa => 'HashRef[Str|CodeRef]', + default => sub { {} }, + lazy => 1, + handles => { + set_option => 'set', + get_option => 'get', + }, +); + +sub add_net_api_declare { + my ($meta, $name, %options) = @_; + + if ($options{useragent}) { + die MooseX::Net::API::Error->new( + reason => "'useragent' must be a CODE ref") + unless ref $options{useragent} eq 'CODE'; + $meta->set_option(useragent => delete $options{useragent}); + } + + # XXX custom authentication_method (replace with before request !) + + # XXX for backward compatibility + for my $attr (qw/base_url format username password/) { + my $attr_name = "api_" . $attr; + if (exists $options{$attr} && !exists $options{$attr_name}) { + $options{$attr_name} = delete $options{$attr}; + } + } + + for my $attr (qw/api_base_url api_format api_username api_password authentication/) { + $meta->set_option($attr => $options{$attr}) if defined $options{$attr}; + } + + # XXX before_request after_request + + if (keys %options) { + # XXX croak + } +} + +1; -- cgit v1.2.3 From 54b15b8276e20b2ce6863ed65f6abf4963ccc363 Mon Sep 17 00:00:00 2001 From: franck cuny Date: Wed, 2 Jun 2010 11:36:25 +0200 Subject: remove code, let the wrapper do the work --- lib/MooseX/Net/API/Meta/Method/APIMethod.pm | 59 +++++++++++++++++++++++++++++ 1 file changed, 59 insertions(+) create mode 100644 lib/MooseX/Net/API/Meta/Method/APIMethod.pm (limited to 'lib/MooseX/Net/API/Meta/Method') diff --git a/lib/MooseX/Net/API/Meta/Method/APIMethod.pm b/lib/MooseX/Net/API/Meta/Method/APIMethod.pm new file mode 100644 index 0000000..b1d0777 --- /dev/null +++ b/lib/MooseX/Net/API/Meta/Method/APIMethod.pm @@ -0,0 +1,59 @@ +package MooseX::Net::API::Meta::Method::APIMethod; + +use Moose::Role; +use MooseX::Net::API::Error; +use MooseX::Net::API::Meta::Method; +use MooseX::Types::Moose qw/Str ArrayRef/; + +has local_api_methods => ( + traits => ['Array'], + is => 'ro', + isa => ArrayRef [Str], + required => 1, + default => sub { [] }, + auto_deref => 1, + handles => { + _get_api_method => 'grep', + _add_api_method => 'push', + _all_api_methods => 'elements', + }, +); + +before add_net_api_method => sub { + my ($meta, $name) = @_; + if (my @method = $meta->_get_api_method(sub {/^$name$/})) { + die MooseX::Net::API::Error->new( + reason => "method '$name' is already declared in " . $meta->name); + } +}; + +sub add_net_api_method { + my ($meta, $name, %options) = @_; + + my $code = delete $options{code}; + $meta->add_method( + $name, + MooseX::Net::API::Meta::Method->wrap( + name => $name, + package_name => $meta->name, + body => $code, + %options + ), + ); + $meta->_add_api_method($name); +} + +after add_net_api_method => sub { + my ($meta, $name, %options) = @_; + $meta->add_before_method_modifier( + $name, + sub { + my $self = shift; + die MooseX::Net::API::Error->new( + reason => "'api_base_url' have not been defined") + unless $self->api_base_url; + } + ); +}; + +1; -- cgit v1.2.3 From 6b5a00cab381d5ed55d662be44b67112e13fbb1c Mon Sep 17 00:00:00 2001 From: franck cuny Date: Wed, 2 Jun 2010 18:56:01 +0200 Subject: clean code --- lib/MooseX/Net/API/Meta/Method/APIDeclare.pm | 24 +++++++++++++++++------- 1 file changed, 17 insertions(+), 7 deletions(-) (limited to 'lib/MooseX/Net/API/Meta/Method') diff --git a/lib/MooseX/Net/API/Meta/Method/APIDeclare.pm b/lib/MooseX/Net/API/Meta/Method/APIDeclare.pm index 4ad5150..b65ef41 100644 --- a/lib/MooseX/Net/API/Meta/Method/APIDeclare.pm +++ b/lib/MooseX/Net/API/Meta/Method/APIDeclare.pm @@ -14,6 +14,22 @@ has options => ( get_option => 'get', }, ); +has accepted_options => ( + is => 'ro', + traits => ['Array'], + isa => 'ArrayRef[Str]', + default => sub { + [ qw/api_base_url + api_format + api_useranem + api_password + authentication + authentication_method/ + ]; + }, + lazy => 1, + auto_deref => 1, +); sub add_net_api_declare { my ($meta, $name, %options) = @_; @@ -25,8 +41,6 @@ sub add_net_api_declare { $meta->set_option(useragent => delete $options{useragent}); } - # XXX custom authentication_method (replace with before request !) - # XXX for backward compatibility for my $attr (qw/base_url format username password/) { my $attr_name = "api_" . $attr; @@ -35,15 +49,11 @@ sub add_net_api_declare { } } - for my $attr (qw/api_base_url api_format api_username api_password authentication/) { + for my $attr ($meta->accepted_options) { $meta->set_option($attr => $options{$attr}) if defined $options{$attr}; } # XXX before_request after_request - - if (keys %options) { - # XXX croak - } } 1; -- cgit v1.2.3 From fdb180a73f97d5a1456d5ac3d0a5a844e22d0ea9 Mon Sep 17 00:00:00 2001 From: franck cuny Date: Thu, 3 Jun 2010 08:34:13 +0200 Subject: http-console: a simple http console to do REST query (like http://github.com/cloudhead/http-console) --- lib/MooseX/Net/API/Meta/Method/APIMethod.pm | 1 + 1 file changed, 1 insertion(+) (limited to 'lib/MooseX/Net/API/Meta/Method') diff --git a/lib/MooseX/Net/API/Meta/Method/APIMethod.pm b/lib/MooseX/Net/API/Meta/Method/APIMethod.pm index b1d0777..8185522 100644 --- a/lib/MooseX/Net/API/Meta/Method/APIMethod.pm +++ b/lib/MooseX/Net/API/Meta/Method/APIMethod.pm @@ -30,6 +30,7 @@ before add_net_api_method => sub { sub add_net_api_method { my ($meta, $name, %options) = @_; + # accept blessed method my $code = delete $options{code}; $meta->add_method( $name, -- cgit v1.2.3 From b62c50ed3c9b48d7d964134de5f4ef0fd36a6112 Mon Sep 17 00:00:00 2001 From: franck cuny Date: Thu, 3 Jun 2010 09:50:39 +0200 Subject: update POD --- lib/MooseX/Net/API/Meta/Method/APIDeclare.pm | 28 +++++++++++++++++++++++++++- lib/MooseX/Net/API/Meta/Method/APIMethod.pm | 26 ++++++++++++++++++++++++++ 2 files changed, 53 insertions(+), 1 deletion(-) (limited to 'lib/MooseX/Net/API/Meta/Method') diff --git a/lib/MooseX/Net/API/Meta/Method/APIDeclare.pm b/lib/MooseX/Net/API/Meta/Method/APIDeclare.pm index b65ef41..14fb83d 100644 --- a/lib/MooseX/Net/API/Meta/Method/APIDeclare.pm +++ b/lib/MooseX/Net/API/Meta/Method/APIDeclare.pm @@ -21,7 +21,7 @@ has accepted_options => ( default => sub { [ qw/api_base_url api_format - api_useranem + api_username api_password authentication authentication_method/ @@ -57,3 +57,29 @@ sub add_net_api_declare { } 1; +__END__ + +=head1 NAME + +MooseX::Net::API::Meta::Class::Method::APIDeclare + +=head1 SYNOPSIS + +=head1 DESCRIPTION + +=head1 AUTHOR + +franck cuny Efranck@lumberjaph.netE + +=head1 SEE ALSO + +=head1 LICENSE + +Copyright 2009, 2010 by Linkfluence + +http://linkfluence.net + +This library is free software; you can redistribute it and/or modify +it under the same terms as Perl itself. + +=cut diff --git a/lib/MooseX/Net/API/Meta/Method/APIMethod.pm b/lib/MooseX/Net/API/Meta/Method/APIMethod.pm index 8185522..d55fe82 100644 --- a/lib/MooseX/Net/API/Meta/Method/APIMethod.pm +++ b/lib/MooseX/Net/API/Meta/Method/APIMethod.pm @@ -58,3 +58,29 @@ after add_net_api_method => sub { }; 1; +__END__ + +=head1 NAME + +MooseX::Net::API::Meta::Class::Method::APIMethod + +=head1 SYNOPSIS + +=head1 DESCRIPTION + +=head1 AUTHOR + +franck cuny Efranck@lumberjaph.netE + +=head1 SEE ALSO + +=head1 LICENSE + +Copyright 2009, 2010 by Linkfluence + +http://linkfluence.net + +This library is free software; you can redistribute it and/or modify +it under the same terms as Perl itself. + +=cut -- cgit v1.2.3