From df0971d28c7e8251314efdb278c2a1a7009d30a8 Mon Sep 17 00:00:00 2001 From: franck cuny Date: Tue, 19 Oct 2010 22:00:28 +0200 Subject: small updates on request: * abstract method to execute middlewares on response * on response callback, middlewares can return a Net::HTTP::Spore::Response object * method _request --- lib/Net/HTTP/Spore/Role/Request.pm | 34 ++++++++++++++++++++++++++-------- 1 file changed, 26 insertions(+), 8 deletions(-) (limited to 'lib/Net/HTTP/Spore/Role') diff --git a/lib/Net/HTTP/Spore/Role/Request.pm b/lib/Net/HTTP/Spore/Role/Request.pm index ddd52e6..d22a721 100644 --- a/lib/Net/HTTP/Spore/Role/Request.pm +++ b/lib/Net/HTTP/Spore/Role/Request.pm @@ -33,22 +33,40 @@ sub http_request { } } - if (defined $response) { - map { $_->($response) } reverse @middlewares; - return $response; + return + $self->_execute_middlewares_on_response( $response, @middlewares ) + if defined $response; + + $response = $self->_request($request); + + return $self->_execute_middlewares_on_response( $response, @middlewares ); +} + +sub _execute_middlewares_on_response { + my ($self, $response, @middlewares) = @_; + + foreach my $mw ( reverse @middlewares ) { + my $res = $mw->($response); + $response = $res + if ( defined $res + && Scalar::Util::blessed($res) + && $res->isa('Net::HTTP::Spore::Response') ); } + $response; +} + +sub _request { + my ($self, $request) = @_; + my $result = $self->request($request->finalize); - $response = $request->new_response( + my $response = $request->new_response( $result->code, $result->headers, $result->content, ); - - map { $_->($response) } reverse @middlewares; - - $response; + return $response; } 1; -- cgit v1.2.3 From 7c6e8153b1f257516f62fbc82635ca9aef0267f3 Mon Sep 17 00:00:00 2001 From: franck cuny Date: Tue, 19 Oct 2010 22:01:52 +0200 Subject: by default, no redirect --- lib/Net/HTTP/Spore/Role/UserAgent.pm | 1 + 1 file changed, 1 insertion(+) (limited to 'lib/Net/HTTP/Spore/Role') diff --git a/lib/Net/HTTP/Spore/Role/UserAgent.pm b/lib/Net/HTTP/Spore/Role/UserAgent.pm index 6bfaa5a..9b99ab8 100644 --- a/lib/Net/HTTP/Spore/Role/UserAgent.pm +++ b/lib/Net/HTTP/Spore/Role/UserAgent.pm @@ -15,6 +15,7 @@ has api_useragent => ( my $ua = LWP::UserAgent->new(); $ua->agent( "Net::HTTP::Spore v" . $Net::HTTP::Spore::VERSION . " (Perl)" ); $ua->env_proxy; + $ua->max_redirect(0); return $ua; } ); -- cgit v1.2.3